https://bugs.kde.org/show_bug.cgi?id=475388
Johannes Zarl-Zierl <johan...@zarl-zierl.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/kphotoalbum/-/commit/c |hics/kphotoalbum/-/commit/2
|62626f6c4a5f42fc2518c75aae4 |a138f3ac613d945516e9a885efe
|665e901f9c33 |ab927ee28d68
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Johannes Zarl-Zierl <johan...@zarl-zierl.at> ---
Git commit 2a138f3ac613d945516e9a885efeab927ee28d68 by Johannes Zarl-Zierl.
Committed on 13/10/2023 at 09:09.
Pushed by johanneszarl into branch 'master'.
Fix regression when deleting images
The introduction of AnnotationDialog::Dialog::slotDiscardImages()
reimplemented the things done in Dialog::slotDeleteImage(),
causing duplicated removal of images from the ImagePreviewWidget and
annotation Dialog. This caused a crash when deleting an image via the
delete button of the annotation dialog.
Fortunately, it turns out that the slotDiscardImages function does
everything slotDeleteImage() does, which means that the older code could
simply be removed.
Note: This patch removes the action "annotationdialog-delete-image",
which called Dialog::slotDeleteImage directly, and had a conflicting
default shortcut Ctrl+Delete (conflicting with Viewer -> delete image).
I believe the original intention for that action was to call
ImagePreviewWidget::slotDeleteImage(). Since the action was clearly not
in a working state, I thought it better to remove it entirely.
M +0 -33 AnnotationDialog/Dialog.cpp
M +0 -1 AnnotationDialog/Dialog.h
M +1 -10 AnnotationDialog/ImagePreviewWidget.cpp
M +1 -2 AnnotationDialog/ImagePreviewWidget.h
https://invent.kde.org/graphics/kphotoalbum/-/commit/2a138f3ac613d945516e9a885efeab927ee28d68
--
You are receiving this mail because:
You are watching all bug changes.
