https://bugs.kde.org/show_bug.cgi?id=474556

--- Comment #7 from Noah Davis <noaha...@gmail.com> ---
(In reply to David Edmundson from comment #6)
> I should have read this:
> 
> #7  0x000000000046429e in ViewerWindow::showSavedVideoMessage(QUrl const&)
> (this=0x0, messageArgument=...) at
> /home/nate/kde/src/spectacle/src/Gui/ViewerWindow.cpp:152
> 
> this=0
> 
> ViewerWindow is not instantiated. The lifespan is managed by something else
> and there's effectively a weakpointer for the singleton. 
> 
>     connect(m_videoPlatform.get(), &VideoPlatform::recordingSaved, this,
> [this](const QString &path) {
>         const QUrl url = QUrl::fromUserInput(path, {},
> QUrl::AssumeLocalFile);
>         ViewerWindow::instance()->showSavedVideoMessage(url);
> 
> and several other places are not guarding ViewerWindow::instance().
> 
> It should be either guarded or we should figure the lifespan

What's really weird about this is that it should currently be impossible to
activate this code in a situation where the ViewerWindow is null. You can
currently only start and stop recording while a ViewerWindow is open.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to