https://bugs.kde.org/show_bug.cgi?id=476787

            Bug ID: 476787
           Summary: Build of Valgrind 3.21.0 fails when
                    SOLARIS_PT_SUNDWTRACE_THRP is defined
    Classification: Developer tools
           Product: valgrind
           Version: 3.21.0
          Platform: Other
                OS: Unspecified
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: jsew...@acm.org
          Reporter: kulik...@gmail.com
  Target Milestone: ---

SUMMARY
With commit 7844752299b5472b21fc4df765d4cffdf92c6c3d (Bug 452802 Handle lld 9+
split RW PT_LOAD segments correctly), the newly added
```
+
+        if (inrw2) {
+           inrw = inrw2;
+        } else {
+           inrw = inrw1;
+        }
```
block was incorrectly placed right bellow the `#if
defined(SOLARIS_PT_SUNDWTRACE_THRP)` section, which very much changed the code
as the `SOLARIS_PT_SUNDWTRACE_THRP` section ends with opened `else` intended
for `if (inrw && !di->data_present) {` below.

Moving the section above the ifdef block fixes the issue (path attached).

OBSERVED RESULT
Many elf related tests fail.

EXPECTED RESULT
They should pass.

SOFTWARE/OS VERSIONS
Oracle Solaris 11.4.66 (where SOLARIS_PT_SUNDWTRACE_THRP is defined)

ADDITIONAL INFORMATION
https://sourceware.org/git/?p=valgrind.git;a=commit;h=7844752299b5472b21fc4df765d4cffdf92c6c3d
https://sourceware.org/git/?p=valgrind.git;a=blobdiff;f=coregrind/m_debuginfo/readelf.c;h=b4edb4fe854237f053ae6946dd27a4304a2efc96;hp=ea9c80415b83734f04ed498d5661a0280cd03854;hb=7844752299b5472b21fc4df765d4cffdf92c6c3d;hpb=67b8fef50bfaed0ce5a1d8130836bcef0eafcd4b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to