https://bugs.kde.org/show_bug.cgi?id=477027
Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/kwin/-/commit/6a997b41ae
| |9acccaba8169eb69c354774085f
| |d00
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #3 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit 6a997b41ae9acccaba8169eb69c354774085fd00 by Vlad Zahorodnii.
Committed on 21/11/2023 at 20:11.
Pushed by vladz into branch 'master'.
Fix screen becoming black when its geometry changes while overview is active
Offscreen quick views are repainted in the pre paint step because that
requires a QOpenGLContext and we don't want it to mess with kwin's
opengl context. After a view is updated, its QOpenGLContext is going to
be unbound.
During normal operation mode, it works as expected:
- the view gets updated in the pre paint stage
- kwin opengl context is made current when starting the paint stage
- the offscreen view is painted on the screen
However, effects->renderScreen() has no such separation. The OpenGL
context changes from the pre paint stage will leak to the paint stage.
So we have
- the workspace notifies that the screens have changed
- the screen transform effect sees that, makes opengl context current
and renders the screen
- the offscreen quick view is updated and after OffscreenQuickView
is done, it's going to call QOpenGLContext::doneCurrent()
- effects->renderScreen() calls m_scene->paint()
- since there's no current opengl context, vbo allocation in
GLTexture::render() will fail and nothing will be rendered on the
screen
As a way around it, this change adds a makeOpenGLContextCurrent() call
before the paint stage. It doesn't quite belong there, the opengl
context has to be made current in the paint stage, e.g. by the
ItemRenderer or something. But atm we have no good place where we
could stick it in.
M +5 -1 src/effect/effecthandler.cpp
https://invent.kde.org/plasma/kwin/-/commit/6a997b41ae9acccaba8169eb69c354774085fd00
--
You are receiving this mail because:
You are watching all bug changes.
