https://bugs.kde.org/show_bug.cgi?id=370715

--- Comment #19 from Janek Bevendorff <k...@jbev.net> ---
Created attachment 101608
  --> https://bugs.kde.org/attachment.cgi?id=101608&action=edit
Indenter Patch

Yes, sure, I can append it here. The patch I uploaded includes the failing unit
tests (because the auto bracket modeline) is ignored and is therefore not ready
for merging yet.

Since I couldn't leave it alone, I also experimented a little more with the C++
indenter. It had some functionality to consume characters to allow some sort of
overwrite mode for brackets. That's pretty useful, but it completely breaks
auto brackets. With a resolution for bug #370716 this should be a feature of
the editor component anyway. So I removed that. It causes one unit test which
tests comma consumption to fail, but not in a way that I would say the new
behavior is buggy. With this consumption feature removed and a few more fixes
to semicolon placement, auto brackets seem to work properly even with the C++
indenter. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to