https://bugs.kde.org/show_bug.cgi?id=480881

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kinfocenter/-/commit/2de
                   |                            |76c72b888ebfd853cd8f96ee2d7
                   |                            |5730ea45e9
         Resolution|---                         |FIXED

--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 2de76c72b888ebfd853cd8f96ee2d75730ea45e9 by David Edmundson.
Committed on 07/02/2024 at 13:07.
Pushed by davidedmundson into branch 'master'.

Avoid QML singletons to work with shared QML engines

KCM's were registering singleton instances. This has the lifespan of the
QMLEngine, and we were using objects with the lifespan of the loaded
KCM. Recent changes share the QML engine used between modules.

We have an existing mechanism to link the C++ container to the loaded UI
which is used in all other system settings. Port everything to using the
attached kcm object and adding a getter there.

M  +9    -2    Modules/block_devices/main.cpp
M  +1    -2    Modules/block_devices/ui/main.qml
M  +9    -2    Modules/cpu/main.cpp
M  +1    -2    Modules/cpu/ui/main.qml
M  +9    -2    Modules/egl/main.cpp
M  +1    -2    Modules/egl/ui/main.qml
M  +9    -2    Modules/firmware_security/main.cpp
M  +1    -2    Modules/firmware_security/ui/main.qml
M  +9    -2    Modules/glx/main.cpp
M  +1    -2    Modules/glx/ui/main.qml
M  +10   -3    Modules/interrupts/main.cpp
M  +1    -2    Modules/interrupts/ui/main.qml
M  +11   -4    Modules/kwinsupportinfo/main.cpp
M  +1    -2    Modules/kwinsupportinfo/ui/main.qml
M  +9    -2    Modules/opencl/main.cpp
M  +1    -2    Modules/opencl/ui/main.qml
M  +10   -2    Modules/pci/main.cpp
M  +1    -3    Modules/pci/ui/main.qml
M  +9    -2    Modules/vulkan/main.cpp
M  +1    -2    Modules/vulkan/ui/main.qml
M  +9    -2    Modules/wayland/main.cpp
M  +1    -2    Modules/wayland/ui/main.qml
M  +9    -2    Modules/xserver/main.cpp
M  +1    -2    Modules/xserver/ui/main.qml

https://invent.kde.org/plasma/kinfocenter/-/commit/2de76c72b888ebfd853cd8f96ee2d75730ea45e9

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to