https://bugs.kde.org/show_bug.cgi?id=481793
Jakob Petsovits <jpe...@petsovits.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/powerdevil/-/commit/db4a |ma/powerdevil/-/commit/f996
|6c79bc5f58dccc43805502c5814 |906dffa0c20d87609b1d8f1dc8a
|5ef341ea1 |abe361888
Version Fixed In|6.1.0 |6.0.4
--- Comment #7 from Jakob Petsovits <jpe...@petsovits.com> ---
Git commit f996906dffa0c20d87609b1d8f1dc8aabe361888 by Jakob Petsovits.
Committed on 13/04/2024 at 17:31.
Pushed by jpetso into branch 'Plasma/6.0'.
daemon: Avoid constantly locking ddcutil display handles
Since libddcutil implemented functionality for per-monitor
device lock files, other programs that are also using libddcutil
(such as the ddcutil CLI itself) were blocked from performing
monitor commands because PowerDevil kept all its handles open.
The better way of interacting with libddcutil as a long-running
program is to store a DDCA_Display_Ref for each monitor in question,
use it to get a temporary display handle, and close it again.
Now we can peacefully coexist with other libddcutil programs,
and users can e.g. query their monitor properties again.
As a slight downside, this means it's possible for another program
to set display brightness independently without PowerDevil noticing.
That seems like a smaller evil though, and can't be fixed by simply
using libddcutil itself as it cannot signal any VCP changes.
Common infrastructure such as digitaltrails/ddcutil-service or a
future kernel DRM interface for DDC/CI could help to mitigate this.
FIXED-IN: 6.0.4
(cherry picked from commit db4a6c79bc5f58dccc43805502c58145ef341ea1)
(generateDisplayId() changes extracted from commit a6b9cf5f)
M +20 -24 daemon/backends/upower/ddcutilbrightness.cpp
M +1 -1 daemon/backends/upower/ddcutilbrightness.h
M +70 -14 daemon/backends/upower/ddcutildisplay.cpp
M +4 -2 daemon/backends/upower/ddcutildisplay.h
https://invent.kde.org/plasma/powerdevil/-/commit/f996906dffa0c20d87609b1d8f1dc8aabe361888
--
You are receiving this mail because:
You are watching all bug changes.
