https://bugs.kde.org/show_bug.cgi?id=450705
--- Comment #5 from Mark Wielaard <m...@klomp.org> ---
I haven't reviewed the fully proposal, but in general I like the idea of using
the same mechanism as the syscalls for instrumenting these more complex
instructions. It is at least familiar. You might want to rename
guest_IP_AT_SYSCALL (it looks like it has the right semantics, but looks funny)
and you might want to look at what defines VG_(client_extension). Currently it
is only defined for s390x, so building scheduler.c will break on any other
arch. It should probably be its own function inside scheduler.c with something
like #if defined(VGA_s390x) x390x_... #else VG_(core_panic)("arch doesn't
implement...") #endif.
It would be nice to get this in this week so it makes valgrind -3.23.0-RC1 and
can get a bit wider testing.
--
You are receiving this mail because:
You are watching all bug changes.
