https://bugs.kde.org/show_bug.cgi?id=469184
Noah Davis <noaha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/grap
| |hics/spectacle/-/commit/e19
| |222a86627c8ba5678e3d0c505a5
| |9bbe810212
--- Comment #12 from Noah Davis <noaha...@gmail.com> ---
Git commit e19222a86627c8ba5678e3d0c505a59bbe810212 by Noah Davis.
Committed on 18/04/2024 at 22:31.
Pushed by ndavis into branch 'master'.
Add blur/pixelate strength settings and slider for adjusting them
The strength values are floating point numbers that go from 0 to 1, like
percents.
I chose to make them like percents instead of a scale factor for the pixelate
effect
and a standard deviation (sigma) for the blur effect for the following reasons:
- Making the settings match the internal values used would make them too
dependent on the implementation.
- It would be hard to explain how the values work to users.
- It would be harder to represent the settings in the UI in a reusable way.
I chose a slider instead of a spinbox for the following reasons:
- 0% in a spinbox would imply no effect, but no effect would be useless.
- The minimum position of a slider only implies the minimum value, making it
more semantically flexible.
- The exact values aren't very meaningful, so there's no need to type an exact
percent.
- Sliders are a bit easier to interact with than spinboxes.
- There was plenty of space.
M +58 -19 src/Gui/AnnotationOptionsToolBarContents.qml
M +39 -2 src/Gui/Annotations/AnnotationDocument.cpp
M +5 -0 src/Gui/Annotations/AnnotationDocument.h
M +68 -0 src/Gui/Annotations/AnnotationTool.cpp
M +15 -4 src/Gui/Annotations/AnnotationTool.h
M +91 -54 src/Gui/Annotations/Traits.cpp
M +24 -16 src/Gui/Annotations/Traits.h
M +13 -0 src/Gui/SettingsDialog/spectacle.kcfg
https://invent.kde.org/graphics/spectacle/-/commit/e19222a86627c8ba5678e3d0c505a59bbe810212
--
You are receiving this mail because:
You are watching all bug changes.
