https://bugs.kde.org/show_bug.cgi?id=487912

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
                   |t/1181acfe30557d6646511df8d |t/918cb38c3522ffcc241ac6a22
                   |98d82589878a570             |b6741e41cdd3c30

--- Comment #26 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 918cb38c3522ffcc241ac6a22b6741e41cdd3c30 by David Edmundson, on
behalf of David Edmundson.
Committed on 09/06/2024 at 08:25.
Pushed by davidedmundson into branch 'Plasma/6.0'.

Fix writing ICEAuthority file

Commit 9398f6cf8933055b31506ba155aef2fc2b3561d7 "Remove iceauth
dependency" introduced two bugs:

1) "fp" is never closed, so the generated auth data stays buffered in
   memory for some indeterminate time and the file stays empty on disk.
   This completely breaks authentication and thus also session restore.

2) Checking the return value of IceWriteAuthFileEntry() is inverted (the
   function returns non-zero on success), so warnings are printed iff
   everything goes well.


(cherry picked from commit 0dcf34458d99b07a3d9054ae0c86c656e0dfa7aa)

Co-authored-by: Tomáš Trnka <tomastr...@gmx.com>

M  +7    -2    ksmserver/server.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/918cb38c3522ffcc241ac6a22b6741e41cdd3c30

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to