https://bugs.kde.org/show_bug.cgi?id=488223
Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/kwin/-/commit/21a45c2700 |ma/kwin/-/commit/83fc982391
|906ef7843cee93d7fdab77ee4e9 |20b544573b6c07084325c86e041
|d35 |dff
--- Comment #10 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit 83fc98239120b544573b6c07084325c86e041dff by Vlad Zahorodnii.
Committed on 13/06/2024 at 08:46.
Pushed by vladz into branch 'Plasma/6.1'.
Avoid sending X11 sync request if new logical geometry doesn't change the
device geometry
There are two mechanisms to throttle ConfigureNotify events during
interactive resize:
- either using XSync
- or by a dummy QTimer
The QTimer approach is pretty straightforward: the wm configures the
window, blocks the interactive resize operation and arms a timer to
unblock it some time later in the future.
With the xsync approach, the wm sends an xsync request, makes a
call to XConfigureWindow(), and blocks interactive resize until
the xsync request is acked by the client. When the client sees the
ConfigureNotify event, it is going to repaint and ack the xsync request.
When the xsync request is acked, the wm will apply new geometry and
unblock interactive resize.
After the scaling changes, the logical geometry can have some fractional
part, which gets rounded when configuring the X windows. Due to that,
it's possible to encounter the case where the logical geometry changes,
but the native/device geometry does not due to std::round(). In that
case, the wm should not send an xsync request because the client won't
ack it because the device geometry has not changed.
(cherry picked from commit 21a45c2700906ef7843cee93d7fdab77ee4e9d35)
M +18 -4 src/utils/xcbutils.h
M +16 -7 src/x11window.cpp
https://invent.kde.org/plasma/kwin/-/commit/83fc98239120b544573b6c07084325c86e041dff
--
You are receiving this mail because:
You are watching all bug changes.
