https://bugs.kde.org/show_bug.cgi?id=481254
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-desktop/-/commit/ |ma/plasma-desktop/-/commit/
|e306c63ddbeaccea72a03fbb2c3 |4da2346e42302349422cf7c45e6
|dbd8245addef5 |4e838fb4d630f
--- Comment #15 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 4da2346e42302349422cf7c45e64e838fb4d630f by David Edmundson.
Committed on 17/06/2024 at 12:44.
Pushed by davidedmundson into branch 'master'.
FolderView Positioner: fix dragging files across screens.
f0ede2d83731952012be0d43c77916d18617edb2 fixed a bug in which items
would disappear when dragging between screens. The rationale in the
description was correct. The fix there was to queue the connection of
rowsInserted so that we don't emit move signals before Positioner proxy
model has processed any pending rowsInserted signals.
This was incorrectly simplified in
99a3597285a92531efb09492421fac0a6a2e82dc . The important part isn't to
process it after FolderModel gets a source model set, but to process it
after Positioner gets the source model, which FolderView doesn't know
about and the original bug introduced.
Rather than a straight revert the code is adjusted to emit the move
signal delayed. This is safer than delaying the processing of a signal
with index arguments.
Related: bug 466337
M +10 -4 containments/desktop/plugins/folder/foldermodel.cpp
https://invent.kde.org/plasma/plasma-desktop/-/commit/4da2346e42302349422cf7c45e64e838fb4d630f
--
You are receiving this mail because:
You are watching all bug changes.
