https://bugs.kde.org/show_bug.cgi?id=486825

Joshua Goins <j...@redstrate.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/tokodon/-/commit/1cc98d
                   |                            |bf3f94467e1ff445d16e0dde473
                   |                            |a13687a
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Joshua Goins <j...@redstrate.com> ---
Git commit 1cc98dbf3f94467e1ff445d16e0dde473a13687a by Joshua Goins.
Committed on 06/07/2024 at 16:28.
Pushed by redstrate into branch 'master'.

Only print out HTTP warnings for errors we don't explicitly handle

So when we make HTTP requests, by default we don't handle errors. Doing
so requires setting another callback to handle errors specifically.
We also print out a warning saying a URL 404'd and such so users can
report server errors we maybe should or shouldn't handle.

In some cases this backfires, causing errors to be printed out even if
we handle those error cases specifically. A good example is unified push
support, where we prod the server (who will return a 404 if we don't
have permissions) and this clogs up the logs. Now we consider any
explicit error callback to be considered handled and no longer print an
error in the log.

M  +1    -1    src/account/account.cpp

https://invent.kde.org/network/tokodon/-/commit/1cc98dbf3f94467e1ff445d16e0dde473a13687a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to