https://bugs.kde.org/show_bug.cgi?id=372357
Dmitry Kazakov <dimul...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/kri | |ta/3dffd58b401a04699d24521e | |53492f3214f1caab Resolution|--- |FIXED --- Comment #10 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit 3dffd58b401a04699d24521e53492f3214f1caab by Dmitry Kazakov. Committed on 28/11/2016 at 12:42. Pushed by dkazakov into branch 'rempt/impex-refactoring'. Fix for a crash when saving a document after adding a text shape Summary: This patch should fix a crash that happens after KisShapeLayerCanvas::repaint() is called on a cloned image. Actually, KisShapeLayer::setImage() was implemented incorrectly. It deleted m_d->converter and m_d->paintDevice, although canvas still owned a link to them. Therefore the next coming update crashed the application. Test Plan: I could never reproduce the original bug, I only used the results of Boud's valgrind output. So please test the original bug with the patch before I push it into 3.1 and impex. Reviewers: #krita, rempt Differential Revision: https://phabricator.kde.org/D3452 M +9 -14 libs/ui/flake/kis_shape_layer.cc M +10 -4 libs/ui/flake/kis_shape_layer_canvas.cpp M +6 -3 libs/ui/flake/kis_shape_layer_canvas.h M +5 -0 libs/ui/kis_image_view_converter.cpp M +3 -1 libs/ui/kis_image_view_converter.h https://commits.kde.org/krita/3dffd58b401a04699d24521e53492f3214f1caab -- You are receiving this mail because: You are watching all bug changes.