On Tuesday 25 May 2010, Andreas Scherf wrote: > Am Dienstag, 25. Mai 2010 schrieben Sie: > > On Monday 24 May 2010, Andreas Scherf wrote: > > > 2010/5/24 Alexander Neundorf <neund...@kde.org> > > > > > > > On Monday 24 May 2010, Andreas Scherf wrote: > > > > > 2010/5/24 Alexander Neundorf <neund...@kde.org> > > > > > > > > > > > On Monday 24 May 2010, Andreas Scherf wrote: > > > > > > > No, this is not a patch for the cmake scripts i changed only > > > > > > > the > > > > > > > > cmake > > > > > > > > > > file > > > > > > > > > > > > > for the ffmpegthumbnailer so that it did not search for the > > > > > > > header files > > > > > > > > > > > > Ok. Where is this file ? > > > > > > > > > > cmake.diff in the mail from 21:15 (ok, bad name) . > > > > > > > > Ok, to which file should I apply the patch ? > > > > > > /trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt > > > > Yes, looks better now. > > Also the CHECK_INCLUDE_FILE() calls probably did not really work, since > > they didn't set the CMAKE_REQUIRED_INCLUDES before. > > > > Alex > > Ok, should i commit the changes?
This is "just" for a CMakeLists.txt in kdemultimeda, not for an installed cmake module from kdelibs, so no strong rules for committing apply here. Just go ahead. Alex _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem