> On Jan. 7, 2014, 2:41 p.m., Aurélien Gâteau wrote: > > Ship It!
Given that this was a fairly contentious thing on the previous RR, I'd like to have a second ship it - preferably from dfaure, ervin or skelly. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114885/#review46972 ----------------------------------------------------------- On Jan. 6, 2014, 2:35 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114885/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 2:35 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > This is a cleaned-up version of https://git.reviewboard.kde.org/r/113805/, > with documentation fixes. The discussion there appeared to end up being > largely in favour of this move. > > Obviously, this can only go in once TP1 is done. > > > Remove custom build types > > KDECompilerSettings.cmake no longer alters CMake's built-in build types > or adds its own. The "debug" build type therefore simply sets -g with > no additional flags (rather than -O2 and, depending on the compiler, > some no-inline/no-reorder flags as previously), the "release" build > types no longer set -DQT_NO_DEBUG and the "debugfull", "profile" and > "coverage" build types no longer exist. > > QT_NO_DEBUG is set by Qt's CMake scripts depending on the build type of > Qt itself. "debugfull" mostly set -g3, allowing macro expansion when > debugging; users can set this flag using environment variables if they > wish. "RelWithDebugInfo" should be used instead of "profile" (according > to dfaure); -fprofile-arcs and -ftest-coverage are easy enough to add to > $CXX_FLAGS if they are required (formerly set by "profile" and > "coverage"). > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > 72824e166d03dcc2d089814dc121f08ba998974a > > Diff: https://git.reviewboard.kde.org/r/114885/diff/ > > > Testing > ------- > > Built kcoreaddons on linux with gcc. -DCMAKE_BUILD_TYPE=debugfull works, but > does not set -g. -DCMAKE_BUILD_TYPE=debug does set -g. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
