----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65528 -----------------------------------------------------------
modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment45786> See comment below about PROJECT_VERSION_STRING. modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment45785> Why? modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment45784> PROJECT_VERSION_STRING is deprecated. Use PROJECT_VERSION instead, which provides compatibility with CMake 3's project() command. modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment45787> Hmm... I wonder what happens if you have multiple calls in the same project with different LIB_INSTALL_DIR arguments. Edge case, perhaps, but it's not inconceivable something could compile a 32-bit and 64-bit version, say. tests/ECMGeneratePkgConfigFile/run_test.cmake.config <https://git.reviewboard.kde.org/r/119798/#comment45783> You need to document that this is necessary (well, that or using CMake 3 and the version argument of project(), I guess). - Alex Merry On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119798/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 11:51 a.m.) > > > Review request for Build System, KDE Frameworks and Harald Sitter. > > > Repository: extra-cmake-modules > > > Description > ------- > > So we decided we wanted those .pc files, so I created a small script that > generates one, I haven't used pc in the past, so feedback is welcome. > > > Diffs > ----- > > modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION > tests/CMakeLists.txt 65de038 > tests/ECMGeneratePkgConfigFile/CMakeLists.txt PRE-CREATION > tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc PRE-CREATION > tests/ECMGeneratePkgConfigFile/run_test.cmake.config PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119798/diff/ > > > Testing > ------- > > I added it in KCoreAddons, this is the patch: > diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt > index 26eb5a1..3a07d1c 100644 > --- src/lib/CMakeLists.txt > +++ src/lib/CMakeLists.txt > @@ -188,4 +188,6 @@ install(FILES > > include(ECMGeneratePriFile) > ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS > "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR > ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons) > +ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons > DEPS Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons > INSTALL) > install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) > > This is the result, on my system: > > Name: KF5CoreAddons > Version: 5.1.0 > Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64 > Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons > Requires: Qt5Core > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
