----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119968/#review65750 -----------------------------------------------------------
Looks good to me. Alex? - Albert Astals Cid On set. 2, 2014, 9:15 p.m., Mathieu Tarral wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119968/ > ----------------------------------------------------------- > > (Updated set. 2, 2014, 9:15 p.m.) > > > Review request for Build System and Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > This module uses a cached variable to hold a list of compiler sanitizers > to enable. > It parses that list, checks the sanitizer desired options, then checks the > compiler > support and set the appropriate flags. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > f0d1aefeabd5534944dcfff85b938f9dfa74ec19 > modules/ECMEnableSanitizers.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119968/diff/ > > > Testing > ------- > > cmake -DECM_ENABLE_SANITIZERS=address;undefined > make VERBOSE=1 > > > Thanks, > > Mathieu Tarral > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
