----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/ -----------------------------------------------------------
Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description ------- Windows has a way for executables and shared libraries (DLLs) to contain version information in a machine-readable format. This information can be seen in Explorer in the file properties (http://goo.gl/UbJGte) and also in the tooltip when hovering the file. It's also used by Windows Installer to avoid overwriting an existing DLL with an older version. This change adds a CMake macro to generate a Windows resource script with version information passed to the macro. The macro documentation is a single line, obviously needs work. Diffs ----- modules/ECMCreateVersionResource.cmake PRE-CREATION modules/ECMVersionResource.rc.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121400/diff/ Testing ------- Tested with CMake 3.0.2 in kcoreaddons (review /r/121401), MSVC2013, Windows 7. Explorer tooltip shows description and version. File properties shows all the new information. Thanks, Nicolás Alvarez
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
