> On Jan. 18, 2015, 11:47 p.m., Jeremy Whiting wrote: > > with the ext change to use the 3rd () in the regex I'm getting this here on > > OSX: > > > > gmake[2]: *** No rule to make target 'src/kanagram_SRCS.iconset/icon_.png', > > needed by 'src/kanagram_SRCS.icns'. Stop. > > CMakeFiles/Makefile2:126: recipe for target > > 'src/CMakeFiles/kanagram.dir/all' failed > > > > It's as if it's not setting the whole filename or something, or it's not > > copying the source file into src/kanagram_SRCS.iconset/ as it should, not > > sure.
Copypasta error :-) I forget to change one reference to variable I renamed. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122135/#review74276 ----------------------------------------------------------- On Jan. 19, 2015, 10:01 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122135/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 10:01 p.m.) > > > Review request for Extra Cmake Modules, Ralf Habacker and Jeremy Whiting. > > > Repository: extra-cmake-modules > > > Description > ------- > > This adds an application icon to an executable from PNG files for > Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from > kdelibs, this requires icons to be explicitly listed as arguments > (meaning CMake can tell when ones are added or deleted and reconfigure > as appropriate), and it works with Matthias Benkmann's png2ico tool, as > well as the KDE-Win tool of the same name. > > Currently missing unit tests. Also completely untested (except that > `make test` runs on Linux, so there are no obvious syntax errors). > > With thanks to Ralf Habacker for the initial work on porting > kde4_add_app_icon. > > CHANGELOG: Add ECMAddAppIcon module to add icons to executable targets > on Windows and Mac OS X. > > > Diffs > ----- > > docs/find-module/FindPng2Ico.rst PRE-CREATION > docs/module/ECMAddAppIcon.rst PRE-CREATION > find-modules/FindPng2Ico.cmake PRE-CREATION > modules/ECMAddAppIcon.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122135/diff/ > > > Testing > ------- > > `make test` passes, which just provides a very basic check for syntax errors. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem