----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122941/#review77466 -----------------------------------------------------------
Seems good for me. Ship it :) (I started to create a script to fix all application and rename icon and adapt cmakelists.txt) - Laurent Montel On mars 14, 2015, 12:47 après-midi, Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122941/ > ----------------------------------------------------------- > > (Updated mars 14, 2015, 12:47 après-midi) > > > Review request for Extra Cmake Modules and Laurent Montel. > > > Repository: extra-cmake-modules > > > Description > ------- > > Through a quirk of implementation, old-style icon filenames are accepted > by the new-style ecm_install_icons function. It's too late to change it > now, as that would break existing projects, but we can warn about it. > > > Diffs > ----- > > modules/ECMInstallIcons.cmake 34d5a485c08bb904f13f1da8a80d6835d32e1365 > tests/ECMInstallIconsTest/16-apps-cmake.png > tests/ECMInstallIconsTest/CMakeLists.txt > 85f2d9f55e263c2983167622b3bb74dce21c10d3 > tests/ECMInstallIconsTest/hi16-actions-old-style-name.png PRE-CREATION > tests/ECMInstallIconsTest/subdir/16-apps-cmake.png PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122941/diff/ > > > Testing > ------- > > Tests pass. The test output log shows the warning for the appropriate file, > and not for other files. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
