----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124009/ -----------------------------------------------------------
(Updated June 4, 2015, 8:53 p.m.) Review request for Build System, Phonon, Martin Gräßlin, and Hrvoje Senjan. Repository: phonon Description ------- - qt4 as before - qt5 now uses ECM to set compiler flags and so forth - paths are still coming out of the joint finder file as the variable names in ECM are different and will potentially cause regressions Diffs ----- cmake/CMakeLists.txt c31d4dd88d49a7aa2ed6df3c5349f34a5cdbf916 cmake/FindPhononInternal.cmake 045f777af4d4cb9c9cf707bf72102c92999f490b cmake/PhononQt4.cmake PRE-CREATION cmake/PhononQt5.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124009/diff/ Testing ------- ran cmake with both lineups and it passes, so yay, I guess. kinda crap to test properly Thanks, Harald Sitter
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem