> On Июнь 14, 2015, 10:36 п.п., Alexander Potashev wrote: > > Please add "find_dependency(Qt5Core @REQUIRED_QT_VERSION@)" for > > completeness. > > > > Build of KrossUi currently cannot be disabled. If we wanted to aim server > > environments without QtWidgets, then we first need to make KrossUi optional > > or move it into a separate framework. Until we are done with making KrossUi > > optional, there is almost no point in dropping find_dependency(Qt5Widgets > > [...]). > > Hrvoje Senjan wrote: > >Please add "find_dependency(Qt5Core @REQUIRED_QT_VERSION@)" for > completeness. > > I disagree ;-) > Qt5Core is nowhere to be found in link libraries (offcourse it's used, > but if we want to be literal...). > I can add it though if we agree to also add the Qt5Core target explicitly > in link_libraries. > > Alex Merry wrote: > Yeah, my view is that you should be searching for anything that is in the > list of interface link libraries for exported targets, but not for anything > else. If you drag it in implicitly via `target_link_libraries`, you can > assume it's brought in implicitly via `find_dependency`.
Agreed. Is this patch ready to push then? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review81472 ----------------------------------------------------------- On Май 26, 2015, 8:04 п.п., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123031/ > ----------------------------------------------------------- > > (Updated Май 26, 2015, 8:04 п.п.) > > > Review request for Build System, KDE Frameworks and Alex Merry. > > > Repository: kross > > > Description > ------- > > Only search for public deps in cmake config. > > Open question - shall we search *all* public deps, or minimal ones? e.g. > target 1 link Qt5Core, target 2 links Qt5Gui. Do we search for both, or just > Qt5Core? > > > Diffs > ----- > > KF5KrossConfig.cmake.in e89cee2 > > Diff: https://git.reviewboard.kde.org/r/123031/diff/ > > > Testing > ------- > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
