> On nov. 28, 2015, 6:19 p.m., Alex Merry wrote: > > I'm happy for this to go in, if the Okular and KBibTex projects are happy > > to use it.
>From the Okular side, if it doesn't break anything, i don't care. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/#review88914 ----------------------------------------------------------- On nov. 28, 2015, 12:43 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126183/ > ----------------------------------------------------------- > > (Updated nov. 28, 2015, 12:43 p.m.) > > > Review request for Extra Cmake Modules, Albert Astals Cid and Tobias Koenig. > > > Repository: extra-cmake-modules > > > Description > ------- > > At least Okular and KBibTex include a FindPoppler.cmake module but this one > uses the new ECMFindModuleHelpers and has imported targets. > > --- > > To make FindPoppler.cmake work without pkg-config it also includes this > commit: > > > Use PATH_SUFFIXES in ecm_find_package_handle_library_components() > > > This is required to find poppler without package config as all the headers > are installed in a poppler subdirectory of the include directory > > > Diffs > ----- > > find-modules/FindPoppler.cmake PRE-CREATION > find-modules/FindWayland.cmake c5a56c1635d03acdaf5ccd780b9a358d6f6655fd > modules/ECMFindModuleHelpers.cmake 2044efe1ccf679b738f68aec9b3fb007c449717c > > Diff: https://git.reviewboard.kde.org/r/126183/diff/ > > > Testing > ------- > > Okular can be built using this find module with minor changes. As it doesn't > set various HAVE_POPPLER_0_36 etc. variables that the find module in okular > did, I set those variables in the okular CMakeLists.txt > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
