----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126368/#review89622 -----------------------------------------------------------
Ship it! Well, it is a convenience header, so making it more convenient seems sensible. It might be worth noting this addition in the documentation, though, as anyone depending on ECM versions earlier than 5.18 will have to include the QDebug header themselves. - Alex Merry On Dec. 15, 2015, 5:30 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126368/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 5:30 p.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > In order to use the logging categories created by ECM, > the generated header file has to be included but then > also #include <QDebug> must be added to make it usable > at all for qCDebug/qCWarning stuff. > > So this puts the #include <QDebug> into the generated > header file and thus allowing to include a single header > for qCDebug/qCWarning instead of two. > > > Diffs > ----- > > modules/ECMQtDeclareLoggingCategory.h.in fedecd2 > > Diff: https://git.reviewboard.kde.org/r/126368/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
