----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126546/#review90261 -----------------------------------------------------------
Ship it! For reference, the manual pushing and popping of the policy stack is only needed because you only want it to apply to a single macro, rather than the whole file (and you could just as well put the policy settings outside the macro/endmacro calls). Not sure whether you were aware of that. - Alex Merry On Dec. 28, 2015, 2:34 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126546/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 2:34 p.m.) > > > Review request for Build System and Alex Merry. > > > Repository: kdelibs4support > > > Description > ------- > > This isn't a typo: if CMP0054 is set, then "TEST" is not parsed > as TEST, and the CMP0064 warning doesn't trigger. Or something like that. > cmake isn't getting any simpler. > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 1c41550eaf79cf908c0e34cef7a6aa36bec56aab > > Diff: https://git.reviewboard.kde.org/r/126546/diff/ > > > Testing > ------- > > Applied the same to kdelibs4 and it fixes the warning when compiling one of > my kde4-based apps (fatcrm). > > > Thanks, > > David Faure > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem