----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126939/#review91867 -----------------------------------------------------------
We default to "auto", which means in most cases "submodule", because something like a "system"-provided (read: packaged) qml-box2d does not yet exist in most distros. Defaulting to system would imho be fine if most systems would provide the dependency. It's not uncommon that git repos use submodules for dependencies that are populated at build-time. Or do we break some KDE policy here? Cf. also https://mail.kde.org/pipermail/gcompris-devel/2015-October/004375.html - Holger Kaelberer On Jan. 31, 2016, 3:32 p.m., Sune Vuorela wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126939/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 3:32 p.m.) > > > Review request for Build System and GCompris. > > > Repository: gcompris > > > Description > ------- > > I was negatively surprised to having a default build doing network traffic. > This is an attempt to make the default less surprising > > > Diffs > ----- > > CMakeLists.txt 371b6d3 > > Diff: https://git.reviewboard.kde.org/r/126939/diff/ > > > Testing > ------- > > a default setup now builds without networking > > > Thanks, > > Sune Vuorela > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
