----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review92798 -----------------------------------------------------------
Ship it! Looks like I totally misunderstood this change. It only changes the default if the project's `CMAKE_INSTALL_PREFIX` is the same as the prefix where Qt is installed, and in that case it does make sense to change the subpaths, since it won't put anything outside the given prefix. If Qt is in a different location (eg. self-built project in `~/local`, system Qt in `/usr`), nothing changes. I was concerned because I have seen other projects always try to install stuff in eg. `/etc`, even if `CMAKE_INSTALL_PREFIX` is somewhere in `$HOME`, because some system daemon expects its config there. But that's not the case here :) - Nicolás Alvarez On Feb. 24, 2016, 2:09 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127169/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 2:09 p.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca > Cintora. > > > Repository: extra-cmake-modules > > > Description > ------- > > Make Qt and ECM-based projects use the same directory sctructure (i.e. where > plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that > might be controlled but usually won't. > > In the end, otherwise, people need to keep adapting their systems with > environment variables anyway. All distros end up setting always this setting > as ON, as well as brave developers who don't have separate prefixes for Qt > and KDE. > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake ebd48fa > > Diff: https://git.reviewboard.kde.org/r/127169/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
