----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127432/#review93801 -----------------------------------------------------------
Ship it! I filed http://public.kitware.com/Bug/view.php?id=16026 and I also reviewed the module as a whole. Then I submitted https://git.reviewboard.kde.org/r/127440/ The string(FIND "${ARG_HEADER}" "." pos REVERSE) stuff in this module is odd. It should use get_filename_component(NAME_WE) probably. - Stephen Kelly On March 20, 2016, 10:53 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127432/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 10:53 a.m.) > > > Review request for Extra Cmake Modules and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > If one subdir in the project includes this file, all others can use the > function > but they don't see the value of the variable, which leads to a strange error > > CMake Error at ECM/modules/ECMQtDeclareLoggingCategory.cmake:114 > (configure_file): > configure_file input location <srcdir> is a directory but a file was > expected. > > Happened in KIO, with kio/gui doing include+function call, and then adding > function call in kio/widgets. > > > Diffs > ----- > > modules/ECMQtDeclareLoggingCategory.cmake > 3f7bb79a7f4d98c1480f87b1fffc252f4e159add > > Diff: https://git.reviewboard.kde.org/r/127432/diff/ > > > Testing > ------- > > As described in above. Got the better error message after the fix. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem