----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127445/#review93843 -----------------------------------------------------------
The patch seems to be correct that the CMAKE_INSTALL_PREFIX is needed. However, it can also be simplified by using cmake -E touch, so I pushed a commit doing that: http://commits.kde.org/extra-cmake-modules/928e79cf5d51a3c78d388b7eb972b3dae1ebbb68 - Stephen Kelly On March 21, 2016, 2:49 p.m., Maurizio Paolini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127445/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 2:49 p.m.) > > > Review request for Extra Cmake Modules. > > > Bugs: 360734 > http://bugs.kde.org/show_bug.cgi?id=360734 > > > Repository: extra-cmake-modules > > > Description > ------- > > Avoid creation of a "share" directory owned by root in the source location. > > At "make install" stage, project icons are installed in their correct place. > However a new folder is created > (owned by root, typically) in the current directory, typically in the home > directory. > > This is often inconvenient, since the user is then unable to remove such > directory without root priviledges, and > could also lead to an error at "make install" stage. > One example of this is when the home directory of the user is an NFS mount > from a remote NFS server, in which case > all NFS requests by "root" are remapped on the server to the "nfsnobody" > which would typically prevent root from > creating files in the home directory. > > The cause seems to be in file modules/ECMInstallIcons.cmake: > > file(WRITE \"${installdir}/${theme}/temp.txt\" \"update\") > file(REMOVE \"${installdir}/${theme}/temp.txt\") > > because the standard value or ${installdir} is the relative path "share/icons" > > > Diffs > ----- > > modules/ECMInstallIcons.cmake 3923636 > > Diff: https://git.reviewboard.kde.org/r/127445/diff/ > > > Testing > ------- > > > Thanks, > > Maurizio Paolini > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
