----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127600/#review94674 -----------------------------------------------------------
Seems to make sense, but the IMPORTED target should be called ImageMagick::convert instead of Convert::Convert. ImageMagick is a namespace, and other executables like ImageMagick::compare etc should be in the same one if they get added some day. - Stephen Kelly On April 7, 2016, 11:01 a.m., Andre Heinecke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127600/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 11:01 a.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > This is mainly useful when cross compiling for Windows. On debian there is no > png2ico packaged, but convert is easily available through packages. > Another advantage of convert is that it can also handle 256px png's this is > the reason I've preferred it over png2ico if both would be available. > > > Diffs > ----- > > find-modules/FindConvert.cmake PRE-CREATION > modules/ECMAddAppIcon.cmake ca64314 > > Diff: https://git.reviewboard.kde.org/r/127600/diff/ > > > Testing > ------- > > Built kleopatra for Windows on Debian GNU/Linux with it and checked that the > icon is correctly embedded. > > > Thanks, > > Andre Heinecke > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
