----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129708/#review101639 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Dec. 29, 2016, 2:48 a.m., Leslie Zhai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129708/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2016, 2:48 a.m.) > > > Review request for Extra Cmake Modules and Alex Merry. > > > Bugs: 374195 > http://bugs.kde.org/show_bug.cgi?id=374195 > > > Repository: extra-cmake-modules > > > Description > ------- > > So I just added > > ``` > set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${XSAN_COMPILE_FLAGS}" ) > ``` > > for C project to use Clang Sanitizer. > > > Diffs > ----- > > modules/ECMEnableSanitizers.cmake 9c8a4de > > Diff: https://git.reviewboard.kde.org/r/129708/diff/ > > > Testing > ------- > > testcase for Clang Static Analyzer, and also for Clang Sanitizer > https://github.com/LLVM-China/clang-analyzer.github.io/tree/master/tests > > ``` > cmake .. -DCMAKE_C_COMPILER=clang \ > > -DCMAKE_CXX_COMPILER=clang++ \ > > -DECM_ENABLE_SANITIZERS='address;leak;undefined' \ > > -DCMAKE_BUILD_TYPE=Debug > ``` > > testcase for kcoreaddons and kjs with GNU compiler > > ``` > cmake .. -DCMAKE_INSTALL_PREFIX=/usr \ > > -DECM_ENABLE_SANITIZERS='address;leak;undefined' \ > > -DKDE_INSTALL_LIBDIR=lib \ > > -D_KDE4_DEFAULT_HOME_POSTFIX=4 \ > > -DBUILD_TESTING=ON > ``` > > ``` > cmake .. -DCMAKE_INSTALL_PREFIX=/usr \ > > -DECM_ENABLE_SANITIZERS='address;leak;undefined' \ > > -DKDE_INSTALL_LIBDIR=lib \ > > -DBUILD_TESTING=ON > ``` > > > Thanks, > > Leslie Zhai > >