fvogt added a comment.

  `${KDE_INSTALL_CONFDIR}` should be changed to somewhere else (but maybe in a 
different patch)
  
  IMO `file(APPEND ...)` is the wrong approach, it should collect all 
categories in a variable and only write it out once at the end (with 
configure_file). I'm not fluent in CMake, I'm not sure whether that's actually 
possible that way.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9446

To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system

Reply via email to