vkrause added inline comments.
INLINE COMMENTS
> ECMAndroidDeployQt.cmake:58
> + COMMAND LANG=C cmake
> -DINPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json.in2"
> -DOUTPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json"
> "-DTARGET=$<TARGET_FILE:${QTANDROID_EXPORTED_TARGET}>"
> "-DOUTPUT_DIR=$<TARGET_FILE_DIR:${QTANDROID_EXPORTED_TARGET}>"
> "-DEXPORT_DIR=${CMAKE_INSTALL_PREFIX}"
> "-DECM_ADDITIONAL_FIND_ROOT_PATH=\"${ECM_ADDITIONAL_FIND_ROOT_PATH}\""
> "-DANDROID_EXTRA_LIBS=\"${ANDROID_EXTRA_LIBS}\"" -P
> ${_CMAKE_ANDROID_DIR}/specifydependencies.cmake
> + COMMAND $<TARGET_FILE_DIR:Qt5::qmake>/androiddeployqt --gradle
> --input "${QTANDROID_EXPORTED_TARGET}-deployment.json" --output
> "${EXPORT_DIR}" --android-platform $ENV{ANDROID_NDK_PLATFORM} --deployment
> bundled ${arguments}
> )
This seems to introduce a new assumption on ANDRDOID_NDK_PLATFORM being set as
an environment variable? Should we check for that/document that, or am I
entirely misreading this somehow?
The rest looks good to me.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13403
To: apol, #frameworks
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
