aacid added a comment.
In D18167#398343 <https://phabricator.kde.org/D18167#398343>, @kossebau wrote: > only 3(?) days between proposal and commit was also a very rushy Check your dates better please, it's 9 days > Though then in this very case, my own take is to be pragmatic and see that this change makes sense in the end and that any active KDE software projects which have code left which should not be upgraded to C++11 and more recent standards should simply on their side opt-out from this warning. > > While talking about it, not sure what is the better approach, I have seen different cmake-based approaches: > > string(REPLACE "-Wsuggest-override" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") > > > check_cxx_compiler_flag("-Wno-suggest-override" HAS_WNO_SUGGEST_OVERRIDE) > > if (${HAS_WNO_SUGGEST_OVERRIDE}) > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override" ) > endif() > > > What would cmake professionals use here? The second one seems better to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
