rjvbb updated this revision to Diff 50451. rjvbb added a comment.
This follows David's suggestion, but using `QUERY_IF` instead of the suggested `TRY_IF` to make it clear that this parameter controls the querying of the compiler. I haven't yet tested the new logic exhaustively but the as far as I can tell the macro behaves as intended as used in the two compiler settings modules. I've simplified the `QUERY_IF` conditions in those modules to just "if APPLE". Querying systematically on APPLE seems reasonable because the likelihood that a non-clang compiler is used for building is very small and when it happens we'd probably be dealing with a non-GNU compiler. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16894?vs=50399&id=50451 REVISION DETAIL https://phabricator.kde.org/D16894 AFFECTED FILES kde-modules/KDECompilerSettings.cmake kde-modules/KDEFrameworkCompilerSettings.cmake modules/ECMAddCompilerFlag.cmake To: rjvbb, #build_system, kfunk Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
