cgiboudeaux added a comment.
Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6. It needs a '5' in its name. I'm also unsure about 'KDEBUGSETTINGSDIR'. kdebugsettings is the 'tool to change the debug messages visibility' and it makes it sound like we're still using kdebug :) What about 'DEBUGCATEGORIESDIR' instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns