sitter added inline comments. INLINE COMMENTS
> kossebau wrote in KDECMakeSettings.cmake:243 > Not sure if anyone is using cmake < 3.0 these days, but if, this will be a > surprise box to them, as with some biulds things work (where cmake >= 3.0) > and with some builds not. > > This needs explicit mentioning in the docs, so developers know what they have > to prepare for, also a mention since which ECM version one can rely on this > behaviour. This is cmakes's own behavior. <3.0 has no autorcc to begin with. That being said the only reason I put the if there is because ECM itself is compatible with 2.8.12, so the if seemed appropriate. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
