kossebau updated this revision to Diff 67620. kossebau marked an inline comment as done. kossebau added a comment.
switch to do generation-time decision about deprecated(text) attribute usage GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from both compilers can be expected, so headers should be compatible, too. Though the compiler versions officially supported for KF (and thus ECM)* both support __attribute__ ((__deprecated__(text))), so it can be hardcoded into the generated header without triggering incompatibilities. On Windows mixing compilers seems not expected, so compiler detected at generation time can also be expected at any further header usage time. - https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67584&id=67620 BRANCH addgenerateexportheader REVISION DETAIL https://phabricator.kde.org/D23789 AFFECTED FILES docs/module/ECMGenerateExportHeader.rst modules/ECMGenerateExportHeader.cmake tests/CMakeLists.txt tests/ECMGenerateExportHeaderTest/CMakeLists.txt tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt tests/ECMGenerateExportHeaderTest/consumer/main.cpp tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt tests/ECMGenerateExportHeaderTest/format_version/main.cpp tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt tests/ECMGenerateExportHeaderTest/library/library.cpp tests/ECMGenerateExportHeaderTest/library/library.hpp tests/ECMGenerateExportHeaderTest/library/main.cpp To: kossebau, #frameworks, #build_system Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns