cullmann added inline comments.

INLINE COMMENTS

> davidedmundson wrote in KDEClangFormat.cmake:48
> it's a bit weird to put new files in the source directory when running cmake.
> 
> Copying when running the target clang-format would probably be ok as there 
> you're already doing an explicit operation which changes the source.

If we don't do this per default, user clang-format tooling like via LSP in 
Atom/Vscode/Kate will not work properly before a manual action.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

Reply via email to