dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
I like the idea very much. INLINE COMMENTS > KDEClangFormat.cmake:76 > + else() > + message(STATUS "Could not set up the clang-format target as the > clang-format executable is missing.") > + endif() I wonder if people compiling KF5 modules (and not necessarily planning on contributing) need to be annoyed with such a warning. Maybe we could still define the clang-format target and make it print an error? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
