davidre added a comment.

  In D25626#569714 <https://phabricator.kde.org/D25626#569714>, @kossebau wrote:
  
  > Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper 
condition, due to not being into the windows side of things, so that part 
better has someone check who enters the dark side now and then. :)
  >  Otherwise +1 for this.
  
  
  I used it because it is the same condition inside 
ECMGenerateExportHeader.cmake which enables `__declspec(deprecated(text))`.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  testswin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25626

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

Reply via email to