cullmann added inline comments. INLINE COMMENTS
> kossebau wrote in KF5I18nMacros.cmake.in:52 > This assumes a relative path given. It might make sense to also deal with > absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then > check for existance? Some lines below we anyways do get_filename_component(_tmp_FILE ${_current_FILE} ABSOLUTE) Could we not just use the result of this for both the check + output? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre, #framework_syntax_highlighting, #localization, #build_system Cc: cullmann, ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns