davidedmundson added inline comments. INLINE COMMENTS
> pino wrote in ECMConfiguredInstall.cmake:46-48 > considering we are documenting the input file as `.cmake.in`, should we > enforce this here and ignore any file not ending like that? Maybe. My rationale for not forcing a suffix is sometimes we do this configure dance for .desktop files and there we have to be a bit careful with scripty. But generally it's neater and easier to use when a suffix is used. Currently Plasma is all over the place with what suffix to have, so I picked one at random. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns
