apol added inline comments.
INLINE COMMENTS
> Android.cmake:93
> #
> -# The APK would then be found in ``myapp_build_apk/bin`` in the build
> directory.
> +# You can specify the APK output directory by setting
> ANDROID_APK_INSTALL_DIR.
> +# Otherwise the APK can be found in ``myapp_build_apk/`` in the build
> directory.
ANDROID_APK_INSTALL_DIR should be between quotes like other variables.
Also I'd call the variable ANDROID_APK_OUTPUT_DIR. We have an install concept
already.
> ECMAndroidDeployQt.cmake:85
> add_custom_target(install-apk-${QTANDROID_EXPORTED_TARGET}
> COMMAND adb install -r
> "${EXPORT_DIR}/${QTANDROID_EXPORTED_TARGET}-${CMAKE_ANDROID_ARCH_ABI}.apk"
> )
Needs adapting.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29631
To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy,
michaelh, ngraham, bruns
