On 2/17/23 08:53, David Redondo wrote:
Hi,
I observed that participation in kdereview is fairly low. Usually only the
same few people participate (I have to admit this does not include me either).
Further follow up to their comments tends sometimes to be slow or is missed.
Sometimes it fizzles out completely.
I think nowadays we have better tools to streamline the whole process, which
we are familiar with and make the barrier to participation lower. My idea is
to use Gitlab which we use for normal code review also for the kdereview
process. For example it could be as follows
- Announce the intention to go through kdereview as usual to kde-core-devel
- Create a MR in your project's repo from master branch into an empty
kdereview branch
- Could copy the sanity checklist [1] as task list and check things there
- Reviewers can leave review comments in the familiar web interface
- Commits that fix review comments are pushed to master branch and so update
the code seen in the MR
- Once the reviewers are satisfied and their feedback incorporated, they
approve the MR and it can be closed
Thoughts?
David
[1] https://community.kde.org/ReleasingSoftware#Sanity_Checklist
Hi,
I definitely like the idea of a more structured approach to the review,
e.g. by following a checklist.
Currently it feels somewhat ad-hoc and arbitrary what people suggest (or
don't suggest), and it's not always clear what's "required" to pass and
what's more of an optional suggestion.
Cheers
Nico
