----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ -----------------------------------------------------------
(Updated 2010-11-07 12:54:32.253284) Review request for kdelibs. Changes ------- Modified with Dawit improvements. Next patch (if allowed), modify 185 for loops. @Albert QList provides both STL-style iterators and Java-style iterators. The STL-style iterators are more low-level and more cumbersome to use; on the other hand, they are slightly faster and, for developers who already know STL, have the advantage of familiarity. http://doc.qt.nokia.com/4.7/qlist-const-iterator.html Summary ------- As I do not know if that kind of patches are allowed in the freeze period, I ask for them together. I'll submit them individually. 1. ktimezone. Include a comment with the real use of refCount. 2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in callgrind) 3. netsupp. Remove a memory leak. 4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to nanosleep. Diffs (updated) ----- /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1193582 /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1193582 /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp 1193582 /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp 1193582 Diff: http://svn.reviewboard.kde.org/r/5775/diff Testing ------- No regressions in the unit tests. Working with them. Thanks, Jaime