----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6332/#review9634 -----------------------------------------------------------
Looks good from my point of view! I'd still suggest to wait a few days with committing the patch to collect further feedback (I'm not the maintainer of the class, I just did a few fixes/adjustments there). - Peter On Jan. 15, 2011, 9:37 a.m., Martin Engelmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6332/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2011, 9:37 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > As stated in the bug report, the image on the folder preview should be > enlarged if there is only one image. > > To achieve this there are two images created for the folder: "img" as before > and "oneTileImg". "oneTileImg" starts with the same image as "img", but after > the first thumbnail is generated "oneTileImg" won't be touched. The number of > successfully created thumbnails is counted in "validThumbnails". If only one > thumbnail could be generated, "oneTileImg" is returned. > > The code between lines 566 and 589 in the original thumbnail.cpp was partly > extracted into a new function called "drawSubThumbnail". This is done to > simplify the creation of the second preview. > > The extra effort to create the "oneTileImg" comparable to creating a fifth > preview image for the folder. > > > This addresses bug 240861. > https://bugs.kde.org/show_bug.cgi?id=240861 > > > Diffs > ----- > > /trunk/KDE/kdebase/runtime/kioslave/thumbnail/thumbnail.h 1214477 > /trunk/KDE/kdebase/runtime/kioslave/thumbnail/thumbnail.cpp 1214477 > > Diff: http://svn.reviewboard.kde.org/r/6332/diff > > > Testing > ------- > > Tested using both Dolphin and Konqueror from trunk. > > The thumbnail generation was tested by moving images and files without > thumbnail plug-in to a new folder. Then one file after another was deleted > until only files without thumbnail plug-in were present. > > Also I opened randomly some folders with sub-folders containing large amounts > of images (e.g. oxygen icon set with > 550 action icons) to the performance. > > > Screenshots > ----------- > > Folder thumbnails for oxygen icon set in Konqueror > http://svn.reviewboard.kde.org/r/6332/s/604/ > > > Thanks, > > Martin > >
