> On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote:
> > Please also add the { } around single line blocks (as per kdelibs coding
> > style).
Lets us forget about such nitpicks, okay... If such unnecessary coding styles
were to be enforced, there would be so many lines of code that would need
fixing in this very same file.
> On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote:
> > kdecore/services/kmimetyperepository.cpp, lines 690-692
> > <http://git.reviewboard.kde.org/r/100539/diff/6/?file=8341#file8341line690>
> >
> > QStringList paths;
> > const QByteArray pkgConfigPath = qgetenv("PKG_CONFIG_PATH");
> > if (!pkgConfigPath.isEmpty())
> > paths <<
> > QFile::decodeName(pkgConfigPath).split(QLatin1Char(':'),
> > QString::SkipEmptyParts);
> >
> > paths << QLatin1String("/usr/share/pkgconfig");
> >
Now that is a good idea. Let us avoid unnecessary QString conversions.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100539/#review1190
-----------------------------------------------------------
On Feb. 4, 2011, 1:29 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100539/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2011, 1:29 a.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Summary
> -------
>
> The attached patch is a workaround to the much discussed issue with VLC
> hanging when opening a KDE file dialog. For the details about the causes of
> this bug, see http://lists.kde.org/?t=129572447500001&r=1&w=2 and the bug
> report linked above...
>
>
> This addresses bug 260719.
> http://bugs.kde.org/show_bug.cgi?id=260719
>
>
> Diffs
> -----
>
> kdecore/services/kmimetyperepository.cpp 9f4c3ca
>
> Diff: http://git.reviewboard.kde.org/r/100539/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit
>
>
