> On May 12, 2010, 1:33 p.m., Oswald Buddenhagen wrote: > > > But on the other hand I can suggest probably a better place for this - > > > kdm itself ;) > > > > > no, it may very well make sense to accept way more than what should be > > permitted via the kcm. in fact, my own local setup is totally insecure for > > practical reasons. > > > > i'll polish up the coding style of your patch and commit it in the next few > > days. thanks for the effort. you survived it. :) > > Igor Krivenko wrote: > > i'll polish up the coding style of your patch and commit it in the next > few days. > Thank you very much. I hope this patch will stimulate popularization and > development of KAuth :) > > Cyberbeat wrote: > was this patch committed?
months ago. it should be marked as such ... - Oswald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/3631/#review5634 ----------------------------------------------------------- On May 12, 2010, 11:16 a.m., Igor Krivenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/3631/ > ----------------------------------------------------------- > > (Updated May 12, 2010, 11:16 a.m.) > > > Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and > Frederik Gladhorn. > > > Summary > ------- > > This is a patch for KDM kcontrol module. > It implements Kauth support for changing kdm settings and managing user > images. > It still doesn't support installation/deletion of themes (including > installation via knewstuff). > As far as I know there were plans to port KNewStuff3 to KAuth, so a more > consistent approach is > to rely on the KNewStuff's integration when it's available. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION > /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions > PRE-CREATION > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1125102 > /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1125102 > > Diff: http://svn.reviewboard.kde.org/r/3631/diff > > > Testing > ------- > > > Screenshots > ----------- > > Saving KDM settings > http://svn.reviewboard.kde.org/r/3631/s/360/ > Managing user images > http://svn.reviewboard.kde.org/r/3631/s/361/ > > > Thanks, > > Igor > >
